Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Add optionLabels for dropdowns#120

Merged
maakbaas merged 1 commit intomaakbaas:1.9.0-devfrom
benklop:master
Nov 6, 2021
Merged

Add optionLabels for dropdowns#120
maakbaas merged 1 commit intomaakbaas:1.9.0-devfrom
benklop:master

Conversation

@benklop
Copy link
Copy Markdown
Contributor

@benklop benklop commented Aug 12, 2021

This PR implements the suggestion in #100 (comment) - it adds an optionLabels field that is used to set differing labels and values in dropdown selectors.

While this appears to work, this is my first attempt at React, and I am unsure if this is really complete.

@maakbaas maakbaas changed the base branch from master to 1.9.0-dev November 6, 2021 13:05
@maakbaas maakbaas merged commit 6e3d02e into maakbaas:1.9.0-dev Nov 6, 2021
@maakbaas
Copy link
Copy Markdown
Owner

maakbaas commented Nov 6, 2021

Sorry, for the way too late response, and thank you for doing the effort to add this. I have merged this into the repository.

Thanks!

maakbaas added a commit that referenced this pull request Nov 6, 2021
* Add requestHandler (fixes #119) (#125)

* Add optionLabels (#120)

* Updated generated HTML and docs

* Bump version

Co-authored-by: benklop <benklop@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants